document the mysterious abc part of the header #3880
8000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| several surrogates are being chained. This way, your application is able to | ||
| target individual devices with specific directives. Just make sure each token | ||
| is unique. | ||
|
|
There was a problem hiding this comment.
I think we should turn this into a note, and mostly link to the docs on this, as I think most users won't need to worry about this (but I like the idea of showing people where they can find out more, I didn't know what the abc was before this either).:
.. note::
The ``abc`` part of the header isn't important unless you have multiple "surrogates"
that need to advertise their capabilities. See `Surrogate-Capability Header`_ for details.
Then at the bottom of the page:
.. _`Surrogate-Capability Header`: http://www.w3.org/TR/edge-arch
There was a problem hiding this comment.
I agree, I'll change this later.
There was a problem hiding this comment.
Done and rebased on master (I made the PR on master, not sure why, tell me if you would like me to close it and make another on 2.3)
One can't help but wonder what it is about.
|
👍 Great addition - thanks Grégoire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can't help but wonder what it is about. Disclaimer: I'm far from being a specialist, I barely know varnish. This is what I understand after a cursory reading of this document. Please check this carefully.