8000 Add a missing argument to the PdoSessionHandler by jakzal · Pull Request #3869 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Add a missing argument to the PdoSessionHandler #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2014
Merged

Add a missing argument to the PdoSessionHandler #3869

merged 1 commit into from
May 29, 2014

Conversation

jakzal
Copy link
Contributor
@jakzal jakzal commented May 25, 2014
Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #3868

wouterj
wouterj reviewed May 25, 2014
View reviewed changes
components/http_foundation/session_configuration.rst
@@ -83,7 +83,8 @@ Example usage::
use Symfony\Component\HttpFoundation\Session\Storage\NativeSessionStorage;
use Symfony\Component\HttpFoundation\Session\Storage\Handler\PdoSessionHandler;

$storage = new NativeSessionStorage(array(), new PdoSessionHandler());
$pdo = new \PDO('mysql:dbname=testdb;host=127.0.0.1');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to use "new PDO(...);" to make this example generic

@weaverryan
Copy link
Member

I like it just like this - the \PDO is clear to me - the PDO is less clear (I might think Symfony has some PDO) object. Anyways, thanks Jakub!

@weaverryan weaverryan merged commit fff25ce into symfony:2.3 May 29, 2014
weaverryan added a commit that referenced this pull request May 29, 2014
@weaverryan
bug #3869 Add a missing argument to the PdoSessionHandler (jakzal)
0649c21 
This PR was merged into the 2.3 branch.

Discussion
----------

Add a missing argument to the PdoSessionHandler

| Q	| A
| --- | ---
| Doc fix?	| yes
| New docs? |	no
| Applies to |	all
| Fixed tickets | #3868

Commits
-------

fff25ce Add a missing argument to the PdoSessionHandler.
@jakzal
Copy link
Contributor Author
jakzal commented May 29, 2014

Sorry for late reaction. @weaverryan, I think @wouterj meant the dots instead of constructor arguments and not the leading namespace character.

@xabbuh xabbuh mentioned this pull request May 29, 2014
Merged
@weaverryan
Copy link
Member

oooh, haha, yes, you're right! Well, I like the real example anyways :) (especially since it doesn't really take up extra space).

Thanks!

@jakzal jakzal deleted the session-configuration-fix branch June 7, 2014 18:18
weaverryan added a commit that referenced this pull request Aug 16, 2014
@weaverryan
minor #3890 [Components][HttpFoundation] use a placeholder for the co…
16e346a 
…nstructor arguments (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Components][HttpFoundation] use a placeholder for the constructor arguments

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

As suggested by @wouterj in #3869.

Commits
-------

631d673 use a placeholder for the constructor arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakzal @weaverryan @wouterj
0