8000 Documentation of the new PSR-4 class loader. by derrabus · Pull Request #3686 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Documentation of the new PSR-4 class loader. #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2014
Merged

Documentation of the new PSR-4 class loader. #3686

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17166bd
First shot of a documentation of the new PSR-4 class loader.
derrabus Mar 12, 2014
6f2a1a3
Adjustments from comments be @WouterJ
derrabus Mar 16, 2014
a05da41
Minor corrections.
derrabus Mar 17, 2014
16fead4
Adjustments from comments by @bicpi
derrabus Mar 17, 2014
cb2be4a
Moved versionadded block to the top.
derrabus Mar 17, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Moved versionadded block to the top.
  • Loading branch information
@derrabus
derrabus committed Mar 17, 2014
commit cb2be4ab4df34a6aa02726c665e566d9ed31a849
4 changes: 2 additions & 2 deletions components/class_loader/psr4_class_loader.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
The PSR-4 Class Loader
======================

Libraries that follow the `PSR-4`_ standard can be loaded with the ``Psr4ClassLoader``.

.. versionadded:: 2.5
The :class:`Symfony\\Component\\ClassLoader\\Psr4ClassLoader` was
introduced in Symfony 2.5.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move this above the first paragraph.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not. /ping @wouterj

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's also what I meant.

Btw, you can trust @xabbuh's comments, he has much experience with the symfony docs & reviews :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do trust him, I just wanted to hear your opinion because you suggested to add this paragraph. :-)


Libraries that follow the `PSR-4`_ standard can be loaded with the ``Psr4ClassLoader``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a versionadded block before this, saying it's new in 2.5:

.. versionadded:: 2.5
    The :class:`Symfony\\Component\\ClassLoader\\Psr4ClassLoader`` was
    introduced in Symfony 2.5.


.. note::

If you manage your dependencies via Composer, you get a PSR-4 compatible
Expand Down
0