8000 Added some examples to the "services as parameters" section by javiereguiluz · Pull Request #3641 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Added some examples 8000 to the "services as parameters" section #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Added some examples to the "services as parameters" section #3641

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member
Q A
Doc fix? no
New docs? yes
Applies to 2.3+
Fixed tickets no

@@ -344,6 +344,16 @@ Start the string with ``@`` or ``@?`` to reference a service in YAML.
* ``@?mailer`` references the ``mailer`` service. If the service does not
exist, it will be ignored;

.. code-block:: yaml

# app/config/config.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 on using the file comments here. It's in the components section, talking about how to integrate the component standlone in your apps, it shouldn't be based on symfony se conventions

and it should not make any reference to Symfony
@weaverryan
Copy link
Member

I love this - very easy win!

weaverryan added a commit that referenced this pull request Mar 19, 2014
…on (javiereguiluz)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #3641).

Discussion
----------

Added some examples to the "services as parameters" section

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.3+
| Fixed tickets | no

Commits
-------

745f3a6 Removed the file path comments because this doc is for the component and it should not make any reference to Symfony
6abb310 Added some examples to the "services as parameters" section
@weaverryan weaverryan closed this Mar 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0