Update render_without_controller.rst #3637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you change that also in the XML and PHP example? By the way, this should be merged into the 2.3 branch. Don't know if @weaverryan can cerry pick this commit or if it was better open a new pull request against the right branch. |
|
I can patch to a different branch as long as it patches cleanly - so we can assume it's not a problem - thanks @xabbuh :) |
|
ping @xabbuh |
|
Great catch - you're absolutely right :). Cheers Antoine! |
weaverryan
added a commit
that referenced
this pull request
Mar 19, 2014
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #3637). Discussion ---------- Update render_without_controller.rst It appears that it is not **sharedMaxAge**: 86400 but **sharedAge**: 86400 Commits ------- 68b5aa8 Update render_without_controller.rst 8372382 Update render_without_controller.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that it is not sharedMaxAge: 86400 but sharedAge: 86400