New Data Voter Article (continuation) #3594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| .. seealso:: | ||
|
|
||
| Voters can also be used in other ways, like, for example, blacklisting IP |
There was a problem hiding this comment.
"like, for example" aren't that 2 words saying the same? I would use either "like" or "for example".
weaverryan
added a commit
that referenced
this pull request
Mar 4, 2014
This PR was merged into the 2.3 branch. Discussion ---------- New Data Voter Article (continuation) Hiya guys! This is just a continuation of #3138 by @monbro. I needed to rebase it against the 2.3 branch (which had conflicts), and wanted to proofread it (hence the fresh PR). Please check out my latest commit to see if I've made any mistakes :). | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.3 | Fixed tickets | #2877 Thanks! Commits ------- d3f9383 [#3594] Nice tweaks thanks to @wouterj and @xabbuh 2391758 [#2877][#3138] Proofreading the new voter data permission entry 11aead7 simplified the example 8227270 updated according to the review da7b97e missed one comment 9b91501 updated the docs according to the last review 872a05f updated the link from ACL to the data permissi 9EAC on voters 1fd3b0e updated docs according to the review 5275230 updated with missing fixes f4eb5f3 updated docs according to the reviews ee0def1 improved tip box with additional link to /cookbook/security 731dcad updated page with suggestion from the review 1466fa7 improvements according to the reviews 99b1b0f a couple of changes according to the comments, not finished now 2bda150 create voters_data_permission.rst article
|
Thanks a lot guys! I made all of the changes you suggested and I'm very very happy to have this guy merged into the docs! And also a big thanks to @monbro, who did all of the work :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya guys!
This is just a continuation of #3138 by @monbro. I needed to rebase it against the 2.3 branch (which had conflicts), and wanted to proofread it (hence the fresh PR).
Please check out my latest commit to see if I've made any mistakes :).
Thanks!