8000 Fix build errors by xabbuh · Pull Request #3578 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fix build errors #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Fix build errors #3578

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
05492b2
Clarify parameters conventions
wouterj Jan 31, 2014
ef4014d
fix form type.
yositaniwebware Feb 3, 2014
efaad48
Fixing typo - thanks to @xabbuh
weaverryan Jan 20, 2014
821af3b
bug #3493 Type fix in remove.rst (weaverryan)
weaverryan Feb 11, 2014
d7e8262
bug #3535 fix form type name. (yositani2002)
weaverryan Feb 11, 2014
4436773
Add missing variable assignment
colinodell Feb 3, 2014
819949c
bug #3537 Add missing variable assignment (colinodell)
weaverryan Feb 11, 2014
aaddfcd
Applied comment
wouterj Feb 11, 2014
73adf8b
minor #3528 Clarify service parameters usages (WouterJ)
weaverryan Feb 11, 2014
b8e1e99
Update generic_event.rst
Lumbendil Feb 5, 2014
d275302
bug #3541 Update generic_event.rst (Lumbendil)
weaverryan Feb 11, 2014
e702b34
fix referenced documents names
xabbuh Feb 5, 2014
3e0d1f4
remove empty_data from the list of inherited options, it's documented…
xabbuh Feb 13, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update generic_event.rst 
The $event['data'] field was not set, thus it wouldn't be modified.

Also, the example already had a lowercase string. Uppercased 1 letter.
  • Loading branch information
@Lumbendil @weaverryan
Lumbendil authored and weaverryan committed Feb 11, 2014
commit b8e1e99c136d6fba493cb9743b619bc1f7626ca7
4 changes: 2 additions & 2 deletions components/event_dispatcher/generic_event.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Filtering data::

use Symfony\Component\EventDispatcher\GenericEvent;

$event = new GenericEvent($subject, array('data' => 'foo'));
$event = new GenericEvent($subject, array('data' => 'Foo'));
$dispatcher->dispatch('foo', $event);

echo $event['data'];
Expand All @@ -102,6 +102,6 @@ Filtering data::
{
public function filter(GenericEvent $event)
{
strtolower($event['data']);
$event['data'] = strtolower($event['data']);
}
}
0