Patches end of page #3459
Closed
Patches end of page #3459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets | #3458 |
…time option (bicpi) This PR was merged into the 2.3 branch. Discussion ---------- [Reference][Form Types] Document "with_minutes" time/datetime option | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #3410 (task `time > with_minutes`) The `datetime` field also has a `with_minutes` option. Using the `single_text` widget type might not work as expected using `with_minutes=false` if the browser supports HTML5's `time` input type. Most browsers seem to only support `hh:mm` or `hh:mm:ss` formats for the value attribute (resetting the value to `--:--` if using an hour value only). This might not be the case for every browser because I couldn't find anything in the HTML5 spec that says a partial time cannot be an hour only. I've added a `caution` box for this. Commits ------- 1e88b9d Fix "versionadded" position 8cfb850 [Reference][Form Types] Document "with_minutes" time/datetime option
I just mentioned the fact that `push -f` is usually required when rebasing and explicit that the "2.2 when bugfixing" is a follow up on the previous example (Not necessarily explicit at first).
As per WouterJ request: #3421 (comment)
As per @cordoval suggestion: #3421 (comment)
…warning for when forbidding anonymous users (cordoval) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Custom Authentication Provider] add a note of warning for when forbidding anonymous users | Q | A | | --- | --- | | Doc fix? | yes | | New docs? | no | | Applies to | 2.3+ | | Fixed tickets | #3212 | | License | CC-ASA 3.0 Unported | Sent using [Gush](https://github.com/cordoval/gush) Commits ------- 244d756 add note when forbidding access to anonymous users on custom authentication provider
…e handler proxies (cordoval) This PR was merged into the 2.3 branch. Discussion ---------- [Session Configuration] add clarifying notes on session save handler proxies | Q | A | | --- | --- | | Doc fix? | yes | | New docs? | no | | Applies to | 2.3+ | | Fixed tickets | #2889 | | License | CC-ASA 3.0 Unported | Sent using [Gush](https://github.com/cordoval/gush) Commits ------- 771b862 address comments from @wouterj 2888d00 answer some questions and clarify the best chapter imo from the symfony documentation
…e (nykopol) This PR was merged into the 2.3 branch. Discussion ---------- [Reference][Form Types] Add "max_length" option in form type | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #3410 (task Form -> max_length) Commits ------- b53a227 fix last typo on max length option d6800d3 fix typo in previous commit 391fe30 fix typo in previous commit 2156545 add max_length to form field type
This PR was merged into the 2.3 branch. Discussion ---------- add missing code-block directive | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- 9b1aab8 add missing code-block directive
…bbuh) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #3415). Discussion ---------- [#3334] the data_class option was not introduced in 2.4 | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- c96e6eb [#3334] the data_class option was not introduced in 2.4
This PR was merged into the 2.3 branch. Discussion ---------- add empty_data option where required option is used | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- d9c6a85 add empty_data option where required option is used
…anielcsgomes) This PR was merged into the 2.3 branch. Discussion ---------- Removed code references to Symfony Standard Distribution | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | After talk with @wouterj on #3426 and IRC about references in the standalone Console component to the framework I decided to submit this PR to change the code that have some references to the Symfony Standard Distribution in the code. Commits ------- 4fd7022 Removed code references to Symfony Standard Distribution
This PR was merged into the 2.3 branch. Discussion ---------- Overridden tweak Hi guys! Tiny change (so skipping the PR table) - see #3407 (comment) Thanks! Commits ------- 8f3e6c7 [#3407] Adding a missing section via tip from @wouterj
|
I don't understand why so many commits are attached here, I must have made a mistake but I don't know github enough to fix it. |
|
it is because you created your branch based on 2.3 and you selected master as target (which does not have yet all the latest changes merged in 2.3) |
|
Ok, I saw it in the documentation after having sent my PR. :-( |
|
Please tell me if there's a way to revert my mistake. |
|
You can't change in GitHub the branch on which this should be applied. But @weaverryan can merge this into 2.3 anyway. |
|
Ok, thanks, I should have looked closely to the other PRs. I will update the issue which describe another problem. This PR can be deleted, if it's possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.