-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Review] Added detailed Backwards Compatibility Promise text #3439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
840073c
Added detailed BC promise text
webmozart 7320ed0
Updated BC promise to be valid as of Symfony 2.3
webmozart dacd7ce
Rearranged rules to be more easily understandable
webmozart 79ca9f7
Added information about type compatibility
webmozart 0e925cb
Added tables with safe operations
webmozart 44ecf16
Fixed: No parameters must be added (ever) to API class methods
webmozart afadaab
Changed: The last parameters of a method may be removed
webmozart 345410c
Rearranged safe operations to make more sense
webmozart a3ad08c
Removed most of the "cannot" statements which are repeated in the tab…
webmozart 31ab2db
Improved wording
webmozart 502ed95
Added: Some breaking changes to unsafe operations are documented in t…
webmozart 4c5a55d
Rearranged page to have different sections for different user bases
webmozart c6e850d
Language fixes
webmozart db76288
Fixed headings
webmozart 54fd836
Language improvements
webmozart 00c6ebe
Fixed safety statements
webmozart efd3911
Added that adding custom properties is not safe
webmozart dcbe79a
Improved wording
webmozart af3a645
Added note about requesting `@api` tags
webmozart be76644
Added information about internal classes and interfaces
webmozart dfb3e8b
Improved wording
webmozart 6501a35
Added information about changing return types that are classes or int…
webmozart 0c6420f
Added information about changing parameter types
webmozart 69768dd
Improved wording: use -> call, access
webmozart 5a160c5
Added note about deprecated interfaces/classes
webmozart ef1f021
Added note about test classes
webmozart 6d9edf1
Improved wording: Changed "safe" to "guaranteed"
webmozart 8c6c7bf
Simplified usage description
webmozart 4868452
Added prose about the difference between regular/API classes/interfaces
webmozart e11335f
Improved the wording of the "Using Symfony" section
webmozart 25443c0
Improved table formatting
webmozart 11bb879
Grammar
webmozart fd1d912
Typo
webmozart bdd3c03
Implemented changes suggested by @WouterJ
webmozart 2320906
Extracted duplicated text into _api_tagging.rst.inc
webmozart 90c4de6
Mentioned Semantic Versioning in the introduction
webmozart be2251c
Implemented @fabpot's comments
webmozart ce58ee9
Added rules for adding parent interfaces and moving methods/propertie…
webmozart 0717192
Removed useless line break
webmozart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Updated BC promise to be valid as of Symfony 2.3
- Loading branch information
commit 7320ed0c44784da8864d0f6cea08bed807e9cea2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use "The Backwards Compatibility Promise", we didn't speak of "our" release cycle neither
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this feels right here. A promise is something personal, something that has only value if you know who it is from. So I think the first person and use of "our" here makes the document more credible.