8000 New Feature: Change the Default Command in the Console component by dcsg · Pull Request #3426 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content
8000

New Feature: Change the Default Command in the Console component #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 9, 2014
Merged

New Feature: Change the Default Command in the Console component #3426

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b29ab89
Documented the Change the Default Command in the Console component
dcsg Jan 4, 2014
11c7174
Added the version number where the setDefaultCommand was introduced
dcsg Jan 5, 2014
60e2b3e
Added the delete document to avoid broken urls and added a notice that
dcsg Jan 5, 2014
af9eac4
Changed the code to remove references to Symfony Framework since it's
dcsg Jan 5, 2014
730985f
Updated references to the new document
dcsg Jan 5, 2014
012456d
Moved `versionadded` to the right section
dcsg Jan 5, 2014
c23f34e
Applied some suggestions
dcsg Jan 5, 2014
5e97202
Applyed suggestions from @fabpot and @stof
dcsg Jan 7, 2014
c1b2aad
Applied suggestions from Ryan
dcsg Jan 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed the code to remove references to Symfony Framework since it's 
the standalone component
  • Loading branch information
@dcsg
dcsg committed Jan 5, 2014
commit af9eac4f97b1918031c02d3dc395997012682e7a
4 changes: 2 additions & 2 deletions components/console/changing_default_behavior.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ method::

#!/usr/bin/env php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure if the bang comment is used before in the docs, if not I prefer to remove it for consistency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied it from the official documentation, more specific the introduction part of the Console Component

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then we keep this.

<?php
// app/console
// application.php

use Acme\DemoBundle\Command\GreetCommand;
use Acme\Command\GreetCommand;
use Symfony\Component\Console\Application;

$command = new GreetCommand();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does it come from? When I read this document, I might not know about this command described in another part of the documentation. And anyway, this command won't work as a default command, which cannot have any argument... which is a "limitation" that should be explained in this doc.

Expand Down
0