The host parameter has to be in defaults, not requirements #3368
Conversation
|
-1 We may need to improve the text in the sidebar, that's why I leave this open. The sidebar is related to the tip above it:
Here we say that you should set a default domain. Then, we say that you properbly don't want to hardcode it in the routing file, so you can use a parameter for that. Of course, you can also include parameters in the requirements, but that wasn't the idea of this sidebar. |
|
The parameter in the requirements won't work (tested yesterday), that's why I made this PR |
|
@MarieMinasyan the requirement is here to restrict the allowed values for the placeholder. It is not the same than defining a default |
|
@wouterj We already have that nice note above. But what do you think about removing that note and just adding a |
|
@weaverryan I think we should move the tip box above the code block and then indeed add the default setting to the example. That should remove the confusion. |
|
I like it - @MarieMinasyan are you able to make these changes? Let us know! And no worries, if you can't - we can open a new PR. But since you brought up the issue, we'd love to give you credit for your contribution ;). Cheers! |
|
Hi, |
|
Thanks Marie! I do think it's much better now :). Cheers! |
…nts (MarieMinasyan) This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes #3368). Discussion ---------- The host parameter has to be in defaults, not requirements Q | A ------------- | --- Doc fix? | yes New docs? | no Applies to | 2.2+ Also has to be applied to 2.2 & 2.3 branches Commits ------- 8a1afae Moved tip block to remove confusion 9c30509 The host parameter has to be in defaults, not requirements
Also has to be applied to 2.2 & 2.3 branches