8000 Improvements of the CollectionType Documentation by peterrehm · Pull Request #3338 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Improvements of the CollectionType Documentation #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Improvements of the CollectionType Documentation #3338

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98213f7
Enhanced documentation to clearify the require option and added the o…
peterrehm Dec 14, 2013
d47dc3a
Formatted and minor improvements
peterrehm Dec 15, 2013
38b37d4
Fixed explanation of field options
peterrehm Dec 27, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatted and minor improvements
  • Loading branch information
@peterrehm
peterrehm committed Dec 15, 2013
commit d47dc3aeaaf2d25d8d3ef2a3988b0d8ccc21d0b1
6 changes: 3 additions & 3 deletions reference/forms/types/collection.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,13 +336,13 @@ you may want to change the placeholder so that unrelated placeholders are not
replaced with the same value.

delete_empty
~~~~~~~~~~~~~~
~~~~~~~~~~~~

**type**: ``Boolean`` **default**: ``false``

If you want to explicitly remove entirely empty collection entries from your
form you have to set 10000 this option to true. Existing collection entries will
however only be deleted if you have `allow_delete`_ option enabled, otherwise
form you have to set this option to true. However, existing collection entries
will only be deleted if you have the allow_delete_ option enabled. Otherwise
the empty values will be kept.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rewrite this a bit:

However, existing collection entries will only be deleted if you have the allow_delete_ option enabled. Otherwise the empty values will be kept.


Inherited options
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/options/empty_data.rst.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ The true default value of this option depends on the field options:


But you can customize this to your needs. For example, if you want the ``gender`` field to be
set to explicitly ``null`` when no value is selected, you can do it like this:
explicitly set to ``null`` when no value is selected, you can do it like this:

.. code-block:: php

Expand Down
8 changes: 4 additions & 4 deletions reference/forms/types/options/required.rst.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ This is superficial and independent from validation. At best, if you let Symfony
guess your field type, then the value of this option will be guessed from
your validation information.

.. _`HTML5 required attribute`: http://diveintohtml5.info/forms.html

.. note::

The required option does also affect the way how empty data of your form is
being handled. For further details check the :doc:` empty_data</reference/forms/types/options/empty_data.rst.inc>` option.
The required option does also affect the way how empty data of your form is
being handled. For further details check the `empty_data`_ option.

.. _`HTML5 required attribute`: http://diveintohtml5.info/forms.html
0