8000 Documented all parameter types by wouterj · Pull Request #2882 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Documented all parameter types #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2013
Merged

Documented all parameter types #2882

merged 1 commit into from
Aug 25, 2013

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Aug 7, 2013
Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets -

stof
stof reviewed Aug 8, 2013
View reviewed changes
components/dependency_injection/parameters.rst

.. note::

This is not available for Yaml and PHP, because they already have build-in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: built

weaverryan added a commit that referenced this pull request Aug 25, 2013
@weaverryan
Merge pull request #2882 from WouterJ/parameter_types
826591d 
Documented all parameter types
@weaverryan weaverryan merged commit 826591d into symfony:2.2 Aug 25, 2013
weaverryan added a commit that referenced this pull request Aug 25, 2013
@weaverryan
[#2882] Minor tweaks and additional information added
b5c19be
@weaverryan
Copy link
Member

Hey Wouter!

This is a very cool thing to document and just a nice reference to have - so nice work! I made some tweaks and added more information at sha: b5c19be. One specific change was here: b5c19be#L0L331. I'm not familiar with the @@ syntax for a service - when would this be used and what would it do?

Thanks!

@wouterj
Copy link
Member Author
wouterj commented Aug 25, 2013

I'm not familiar with the @@ syntax for a service - when would this be used and what would it do?

The @@ was wrong (that's why I removed that line from the list, but I forgot to change the sentence). As of 2.1, @@ is the escape from @, so @@mailer will be seen as the string "@mailer" instead of a reference to the mailer service.

@wouterj wouterj mentioned this pull request Aug 25, 2013
Merged
weaverryan added a commit that referenced this pull request Aug 26, 2013
@weaverryan
[#2882] Typo fix thanks to @xabbuh
674f04d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterj @weaverryan @stof
0