add notes on collection and entity field types #2428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| If you are working with a collection of Doctrine entities, it will be helpful | ||
| to read the documention for the :doc:`/reference/forms/types/collection` | ||
| as well. In addition, there is a complete example in the cookbook article | ||
| :doc:`/cookbook/form/form_collections`. |
There was a problem hiding this comment.
I think it's safe to move this under the multiple option, since you'll definitely need multiple => true for this to be an issue.
|
I like it! The only improvement that we can't make yet is to link to the addXxx and removeXxx docs that'll be added for #1057. Obviously, we don't need to worry about that now. |
|
Great feedback. Changes made. Removing WIP from title. |
| .. note:: | ||
|
|
||
| If you are working with a collection of Doctrine entities, pay special | ||
| attention to the ``allow_add``, ``allow_delete`` and ``by_reference`` options. |
There was a problem hiding this comment.
I prefer to use reference links here:
attention to the `allow_add`_, `allow_delete`_ and `by_reference`_ options.There was a problem hiding this comment.
That makes sense. PR has been updated accordingly.
|
👍 |
…of entities and cookbook article
weaverryan
added a commit
that referenced
this pull request
Apr 4, 2013
add notes on collection and entity field types
|
big 👍 Thanks Joel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added notes at the top of the collection and entity field types, directing the user to more specific documentation (and the cookbook article) if they are working with collections of Doctrine entities. Hopefully, this will point people in the right direction.