8000 [Book][ServiceContainer] Added docs for YAML '@@' escaping by tPl0ch · Pull Request #2354 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

[Book][ServiceContainer] Added docs for YAML '@@' escaping #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2013

Conversation

tPl0ch
Copy link
@tPl0ch tPl0ch commented Mar 24, 2013

This PR deprecates #2286

Q A
Doc fix? no
New docs? yes symfony/symfony#7357
Applies to 2.1+
Fixed tickets symfony/symfony#4889

value (i.e. a very safe mailer password) in a yaml file, you need to escape
it by adding another ``@`` sign (This only applies to the YAML format):

.. code-block:: yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one indent to much

@wouterj
Copy link
Member
wouterj commented Mar 24, 2013

I've never seen a Travis build on the Symfony Docs :-) (it can be an idea though...)

@@ -231,6 +231,20 @@ looks up the value of each parameter and uses it in the service definition.

<argument type="string">http://symfony.com/?foo=%%s&bar=%%d</argument>

.. note::

If you want to use a string that starts with an ``@`` sign as a parameter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a .. versionadded:: 2.1 directive.

@tPl0ch
Copy link
Author
tPl0ch commented Mar 25, 2013

@wouterj Fixed the outstanding issues. Concerning the Travis build: I just activated the wrong repository :-D

@@ -231,6 +231,21 @@ looks up the value of each parameter and uses it in the service definition.

<argument type="string">http://symfony.com/?foo=%%s&bar=%%d</argument>

.. note::

.. versionadded:: 2.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use something like this:

.. versionadded:: 2.1
    Escaping the ``@`` character is new in Symfony 2.1.

.. note::

    If you want to use ....

@tPl0ch
Copy link
Author
tPl0ch commented Mar 25, 2013

@wouterj Please tell me that I got this right this time, meeeeh.

:-)

@wouterj
Copy link
Member
wouterj commented Mar 25, 2013

@tPl0ch yes, it's perfect now! 👍

@@ -231,6 +231,23 @@ looks up the value of each parameter and uses it in the service definition.

<argument type="string">http://symfony.com/?foo=%%s&bar=%%d</argument>

.. versionadded:: 2.1
Escaping the ``@`` character in YAML parameter values is new in Symfony 2.1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is new in 2.1.9 and 2.2.1, it is not available in 2.1.8 and 2.2.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof I added the specific versions now.

This PR deprecates symfony#2286

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes symfony/symfony#7357
| Applies to    | 2.1
| Fixed tickets | symfony/symfony#4889
@weaverryan weaverryan merged commit ed39ba0 into symfony:2.1 Mar 31, 2013
@weaverryan
Copy link
Member

Hi Thomas!

Very nice - thanks for making all these revision - it was an easy merge.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0