10000 [Validator] Validate SVG ratio in Image validator by MrYamous · Pull Request #20496 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Validate SVG ratio in Image validator #20496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

[Validator] Validate SVG ratio in Image validator #20496

merged 1 commit into from
Jan 2, 2025

Conversation

MrYamous
Copy link
Contributor

Fix #20493

@MrYamous MrYamous requested a review from xabbuh as a code owner December 30, 2024 07:42
@carsonbot carsonbot added this to the 7.3 milestone Dec 30, 2024
@MrYamous MrYamous mentioned this pull request Dec 30, 2024
Merged
@javiereguiluz
Copy link
Member

Thanks Matthieu.

@javiereguiluz javiereguiluz merged commit 5add3eb into symfony:7.3 Jan 2, 2025
3 checks passed
@javiereguiluz javiereguiluz mentioned this pull request Jan 2, 2025
Closed
javiereguiluz added a commit that referenced this pull request Jan 2, 2025
@javiereguiluz
minor #20497 [Validator] Cannot validate svg image size (MrYamous)
5e7bf61 
This PR was merged into the 6.4 branch.

Discussion
----------

[Validator] Cannot validate svg image size

As an addition of #20496 and considering what is described in related [code PR](symfony/symfony#59265) I think it can be helpful to explicit mention this restriction for SVG images

Commits
-------

248d4ff cannot validate svg image size
@MrYamous MrYamous deleted the validator/image-svg branch January 2, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
4 participants
@MrYamous @javiereguiluz @xabbuh @carsonbot
0