8000 [Validator] Add `CompoundConstraintTestCase` to ease testing Compound constraints by alexandre-daubois · Pull Request #20150 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

[Validator] Add CompoundConstraintTestCase to ease testing Compound constraints #20150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

alexandre-daubois
Copy link
Member
@alexandre-daubois alexandre-daubois commented Aug 22, 2024

Fix #20148

May be tweaked a bit if symfony/symfony#58064 passes.

@carsonbot carsonbot added this to the 7.2 milestone Aug 22, 2024
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Aug 22, 2024
…Case` (alexandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

[Validator] Add ``@template`` on `CompoundConstraintTestCase`

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | -
| License       | MIT

While writing [the docs](symfony/symfony-docs#20150), I realized ``@template`` could be added. Moreover, it is already present on `ConstraintValidatorTestCase`.

Commits
-------

618215a [Validator] Add ``@template`` on CompoundConstraintTestCase`
@xabbuh
Copy link
Member
xabbuh commented Aug 23, 2024

@alexandre-daubois symfony/symfony#58064 has been merged

@alexandre-daubois
Copy link
Member Author

Thanks! Updated

@javiereguiluz javiereguiluz merged commit 84a9a57 into symfony:7.2 Aug 26, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Alex, another awesome contribution! You're on a roll! Thanks 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0