[Translation] [Crowdin] Add a tip about language mapping #19325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01aeb67 to
0aec4ed
Compare
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Dec 26, 2023
…i-bodnar) This PR was submitted for the 6.4 branch but it was merged into the 6.3 branch instead. Discussion ---------- [Translation][Crowdin] Use project language mapping | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Sometimes the locale codes may be different from the [codes](https://developer.crowdin.com/language-codes/) used in the Crowdin API. This will cause API errors because the wrong code is passed in the upload and download translation requests. There was already a fix (#50040), but it only works partially. The suggested approach uses the [language mapping](https://support.crowdin.com/project-settings/#languages) configured in the Crowdin project. If the locale code and the crowdin code are different, the user needs to configure the language mapping in the Crowdin project. Documentation - symfony/symfony-docs#19325 Commits ------- a1d2f67 [Translation] Crowdin Bridge: use the project language mapping
|
Could target 6.3 since I've merged symfony/symfony#53178 on 6.3 |
|
@nicolas-grekas thank you, I'll rebase |
0aec4ed to
e9c44f4
Compare
|
Thank you Andrii. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR - symfony/symfony#53178