8000 [Cache] Fix PdoAdapter examples by HypeMC · Pull Request #19116 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Fix PdoAdapter examples #19116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

[Cache] Fix PdoAdapter examples #19116

merged 1 commit into from
Nov 7, 2023

Conversation

HypeMC
Copy link
Contributor
@HypeMC HypeMC commented Nov 6, 2023

As mentioned in symfony/symfony#52460, using a DSN with the PdoAdapter is currently not supported, instead a service name should be provided, eg:

app.my_pdo_service:
    class: \PDO
    arguments:
        - 'pgsql:host=localhost'

I haven't included the actual service definition since app.my_psr6_service isn't included either, but if you think I should, please let me know.

@carsonbot carsonbot added this to the 5.4 milestone Nov 6, 2023
@OskarStark
Copy link
Contributor

Should we add your example for PDO?

@HypeMC HypeMC force-pushed the fix-pdo-adapter-example branch from c588f38 to 7ab6c81 Compare November 7, 2023 08:47
@HypeMC
Copy link
Contributor Author
HypeMC commented Nov 7, 2023

@OskarStark Done

@OskarStark
Copy link
Contributor

Thank you @HypeMC.

@OskarStark OskarStark merged commit c8cdd53 into symfony:5.4 Nov 7, 2023
@HypeMC HypeMC deleted the fix-pdo-adapter-example branch November 7, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Cache Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@HypeMC @OskarStark @carsonbot
0