10000 [Notifier] Add GoIP bridge by ahmedghanem00 · Pull Request #18742 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] Add GoIP bridge #18742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2023
Merged

[Notifier] Add GoIP bridge #18742

merged 1 commit into from
Aug 14, 2023

Conversation

ahmedghanem00
Copy link
Contributor
@ahmedghanem00 ahmedghanem00 commented Aug 11, 2023 •
edited
Loading

To follow-up with symfony/symfony#51349

@carsonbot carsonbot added this to the 6.4 milestone Aug 11, 2023
@ahmedghanem00 ahmedghanem00 mentioned this pull request Aug 11, 2023
Closed
@OskarStark OskarStark added Waiting Code Merge Docs for features pending to be merged and removed Status: Reviewed labels Aug 12, 2023
@carsonbot carsonbot modified the milestones: 6.4, next Aug 12, 2023
fabpot added a commit to symfony/symfony that referenced this pull request Aug 12, 2023
@fabpot
feature #51349 [Notifier] Add GoIP bridge (ahmedghanem00)
bacbe8d 
This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Notifier] Add GoIP bridge

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#18742
| Recipes       | symfony/recipes#1233

GoIP is a GSM Gateway/SIM-Hub that provides the ability to send SMS messages over the network. I think it would be useful to add an integration for it with the Symfony Notifier

Commits
-------

066d0f8 [Notifier] Add GoIP bridge
@xabbuh xabbuh modified the milestones: next, 6.4 Aug 13, 2023
@xabbuh xabbuh removed the Waiting Code Merge Docs for features pending to be merged label Aug 13, 2023
@OskarStark
Copy link
Contributor

Thanks for your work on this new feature!

@OskarStark OskarStark merged commit fe9eefd into symfony:6.4 Aug 14, 2023
@ahmedghanem00 ahmedghanem00 deleted the goip-notifier branch August 14, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedghanem00 @OskarStark @xabbuh @carsonbot
0