8000 [Cache] Add missing backtick by rylixs · Pull Request #18707 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

[Cache] Add missing backtick #18707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

rylixs
Copy link
Contributor
@rylixs rylixs commented Aug 6, 2023

👋

A backtick was missing on this part since version 6.2 of this page.

@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.3, 6.4, 7.0.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 6.2 milestone Aug 6, 2023
@javiereguiluz javiereguiluz modified the milestones: 6.2, 6.3 Aug 7, 2023
@javiereguiluz
Copy link
Member

Good catch! @rylixs thanks and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz changed the base branch from 6.2 to 6.3 August 7, 2023 06:45
@javiereguiluz javiereguiluz force-pushed the cache-expiration-backtick branch from 3981b45 to 0f1f5db Compare August 7, 2023 06:45
@javiereguiluz javiereguiluz merged commit ab8728f into symfony:6.3 Aug 7, 2023
@rylixs rylixs deleted the cache-expiration-backtick branch August 7, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0