10000 [Doctrine] fix `AsDoctrineListener` github link in `Doctrine Events` doc by MirakuSan · Pull Request #18661 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Doctrine] fix AsDoctrineListener github link in Doctrine Events doc #18661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2023
Merged

[Doctrine] fix AsDoctrineListener github link in Doctrine Events doc #18661

merged 1 commit into from
Aug 1, 2023

Conversation

MirakuSan
Copy link

Hello,

I am fixing a dead link in Doctrine Events page.

This is my first Symfony doc contribution, I hope I am doing it right.

@MirakuSan MirakuSan changed the title 🐛 Bug(doctrine event): fixing AsDoctrineListener github link in Doctrine Events doc [Doctrine] fix AsDoctrineListener github link in Doctrine Events doc Aug 1, 2023
@MirakuSan MirakuSan force-pushed the fix/doctrine-event-as-doctrine-listener-link branch from 33c5221 to 1fb3f4d Compare August 1, 2023 08:48
@carsonbot carsonbot changed the title [Doctrine] fix AsDoctrineListener github link in Doctrine Events doc fix AsDoctrineListener github link in Doctrine Events doc Aug 1, 2023
@OskarStark OskarStark added this to the 5.4 milestone Aug 1, 2023
@MirakuSan MirakuSan changed the title fix AsDoctrineListener github link in Doctrine Events doc [Doctrine] fix AsDoctrineListener github link in Doctrine Events doc Aug 1, 2023
@javiereguiluz javiereguiluz modified the milestones: 5.4, 6.3 Aug 1, 2023
@javiereguiluz
Copy link
Member

Damien, you did it perfectly! Thanks a lot and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit d5b31d5 into symfony:6.3 Aug 1, 2023
@MirakuSan MirakuSan deleted the fix/doctrine-event-as-doctrine-listener-link branch August 1, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@MirakuSan @javiereguiluz @OskarStark @carsonbot
0