[Form] Improve form type methods explanation #18585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jul 20, 2023
Member
|
I'm very glad to merge your improvements to forms docs! Thanks a lot Jules! |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Aug 2, 2023
…ds (HeahDude) This PR was merged into the 6.4 branch. Discussion ---------- [Form] Use logical ordering for type and extension methods | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | symfony/symfony-docs#18585 Related docs PR has already been merged. IMHO having methods ordered the same way that the component uses them gives a better understanding of how it works (same as having a "supports()" method defined first in a class like `Voter`). It would be nice to reorder them in core implementations as well, by accepting such changes in 5.4, it would not cause conflicts when merging branches, WDYT? Commits ------- 40bfbbd [Form][DX] Use logical ordering for type and extension methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to keep methods ordered the same way they are used by the component:
getParent(): a type is first configured by its parent and its parent extensionsconfigureOptions(): a type defines what options are availablebuildForm(): a type configures the current form and its fields based on defined optionsbuildView(): a type configures its view based on the built form and defined optionsfinishView(): a type configures its child views based on the built form, built view and defined options