8000 [Console] Add `ProgressIndicator` page by alexandre-daubois · Pull Request #18582 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Console] Add ProgressIndicator page #18582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

[Console] Add ProgressIndicator page #18582

merged 1 commit into from
Jul 20, 2023

Conversation

alexandre-daubois
Copy link
Member

Fix #18580

@carsonbot carsonbot added this to the 5.4 milestone Jul 18, 2023
welcoMattic
welcoMattic reviewed Jul 18, 2023
View reviewed changes
components/console/helpers/progressindicator.rst Outdated

Instead of using the built-in indicator values, you can also set your own::

$progressIndicator = new ProgressIndicator($output, 'verbose', 100, ['o', 'O']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 suggestion: ‏Could we use ['⠏', '⠛', '⠹', '⢸', '⣰', '⣤', '⣆', '⡇'] to show a more "modern" spinner?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah definitely, thanks!

@javiereguiluz javiereguiluz merged commit 611eb54 into symfony:5.4 Jul 20, 2023
@javiereguiluz
Copy link
Member

A lovely contribution of an interesting missing feature. Thanks a lot Alex!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welcoMattic welcoMattic welcoMattic left review comments

@alamirault alamirault alamirault approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandre-daubois @javiereguiluz @welcoMattic @alamirault @carsonbot
0