8000 [Encore] Webpack Dev Server: live reload & HMR by ne0-cz · Pull Request #18538 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Encore] Webpack Dev Server: live reload & HMR #18538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

[Encore] Webpack Dev Server: live reload & HMR #18538

merged 1 commit into from
Jul 20, 2023

Conversation

ne0-cz
Copy link
Contributor
@ne0-cz ne0-cz commented Jul 7, 2023

To use both live reload and HMR, some options are required and I think the docs would be a perfect place to find them.

@carsonbot carsonbot added this to the 5.4 milestone Jul 7, 2023
@javiereguiluz
Copy link
Member

Thanks for this proposal.

Before merging, let's ping some JavaScript expert (like @stof or @weaverryan) to see if they can review these changes. Thanks!

@weaverryan
Copy link
Member

I've never considered having the browser "live reload" when you change PHP or Twig files. Is that a common thing people want/do?

@ne0-cz
Copy link
Contributor Author
ne0-cz commented Jul 10, 2023

I don't really know what people want/do, I can only speak about my experience - a full-stack developer.

When I work on some JS-related feature I'll be definitely editing both the JS files and Twig templates. And since the JS changes are automatically updated in the browser without needing to manually reload it, I'm used to the same behavior even with template changes.

The static.watch option wasn't easy to figure out. This is exactly the place that'd help me solve it..

weaverryan
weaverryan reviewed Jul 11, 2023
View reviewed changes
Copy link
Member
@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose changing the section title. But otherwise, sure, this might be useful 👍

@ne0-cz ne0-cz requested a review from weaverryan July 17, 2023 13:20
@javiereguiluz
Copy link
Member

Nice doc update! Luděk thanks and congrats on your first Symfony Docs contribution 🎉 Thanks also to Ryan for his review!

@javiereguiluz javiereguiluz merged commit 60c277d into symfony:5.4 Jul 20, 2023
@javiereguiluz javiereguiluz force-pushed the frontend_hmr_livereload branch from 97256c1 to 0b3ff04 Compare July 20, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
Encore Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ne0-cz @javiereguiluz @weaverryan @carsonbot
0