10000 [Validator] Update `Type` constraint, add `number`, `finite-float` and `finite-number` validations by guillaume-a · Pull Request #18527 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Update Type constraint, add number, finite-float and finite-number validations #18527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

[Validator] Update Type constraint, add number, finite-float and finite-number validations #18527

merged 1 commit into from
Jul 31, 2023

Conversation

guillaume-a
Copy link
Contributor
@guillaume-a guillaume-a commented Jul 6, 2023 •
edited by OskarStark
Loading

@guillaume-a guillaume-a requested a review from xabbuh as a code owner July 6, 2023 19:50
@carsonbot carsonbot added this to the 6.4 milestone Jul 6, 2023
@guillaume-a guillaume-a mentioned this pull request Jul 6, 2023
Merged
@guillaume-a guillaume-a force-pushed the 50782 branch 2 times, most recently from 6e07c22 to 74c74b7 Compare July 6, 2023 20:04
@guillaume-a
Copy link
Contributor Author

This PR should fix CI / Build : #18529

@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Jul 6, 2023
@carsonbot carsonbot modified the milestones: 6.4, next Jul 6, 2023
@OskarStark
Copy link
Contributor

IsFinite != Finite

@guillaume-a guillaume-a changed the title [Validator] Add Finite constraint [Validator] Add IsFinite constraint Jul 13, 2023
@guillaume-a
Copy link
Contributor Author

@OskarStark you're right, I renamed the Validator IsFinite

fabpot
fabpot requested changes Jul 30, 2023
View reviewed changes
reference/constraints/IsFinite.rst Outdated
IsFinite
========

Validates that a value is a legal finite number.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Validates that a value is a legal finite number.
Validates that a value is a valid finite number.

fabpot added a commit to symfony/symfony that referenced this pull request Jul 30, 2023
@fabpot
feature #50907 [Validator] Update Type 8000 constraint, add number, `f…
f404704 
…inite-float` and `finite-number` validations (guillaume-a)

This PR was merged into the 6.4 branch.

Discussion
----------

[Validator] Update `Type` constraint, add `number`, `finite-float` and `finite-number` validations

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #50782
| License       | MIT
| Doc PR        | symfony/symfony-docs#18527

Contraint `Type(['float'])` can produce positives with INF or NAN.
This new types car narrow validation and limit validation to finite numbers.

```
#[Assert\Type(['int', 'finite-float'])]
private $value;
```

Thank you for helping me with this one.

Commits
-------

c3b5709 [Validator] Update `Type` constraint, add `number`, `finite-float` and `finite-number` validations
symfony-splitter pushed a commit to symfony/validator that referenced this pull request Jul 30, 2023
@fabpot
feature #50907 [Validator] Update Type constraint, add number, `f…
d539c89 
…inite-float` and `finite-number` validations (guillaume-a)

This PR was merged into the 6.4 branch.

Discussion
----------

[Validator] Update `Type` constraint, add `number`, `finite-float` and `finite-number` validations

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #50782
| License       | MIT
| Doc PR        | symfony/symfony-docs#18527

Contraint `Type(['float'])` can produce positives with INF or NAN.
This new types car narrow validation and limit validation to finite numbers.

```
#[Assert\Type(['int', 'finite-float'])]
private $value;
```

Thank you for helping me with this one.

Commits
-------

c3b5709560 [Validator] Update `Type` constraint, add `number`, `finite-float` and `finite-number` validations
@guillaume-a guillaume-a changed the title [Validator] Add IsFinite constraint [Validator] Update Type constraint, add number, finite-float and finite-number validations Jul 31, 2023
@guillaume-a
Copy link
Contributor Author
guillaume-a commented Jul 31, 2023 •
edited
Loading

I've re write the doc according to all changes done in the initial ticket.
No more IsFinite constraint, just some new entries in Type constraint.

@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Jul 31, 2023
OskarStark
OskarStark approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my comment

@OskarStark
Copy link
Contributor

Thank you Guillaume.

@OskarStark OskarStark merged commit 03d356b into symfony:6.4 Jul 31, 2023
@guillaume-a guillaume-a deleted the 50782 branch July 31, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
4 participants
@guillaume-a @OskarStark @fabpot @carsonbot
0