8000 [Routing] Remove annotations from Creating Pages article by javiereguiluz · Pull Request #18484 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Remove annotations from Creating Pages article #18484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2023
Merged

[Routing] Remove annotations from Creating Pages article #18484

merged 1 commit into from
Jul 4, 2023

Conversation

javiereguiluz
Copy link
Member

Someone reported this in Symfony Slack.

The page_creation.rst page is very important because it's linked from the Symfony Welcome Page and it's consumed by newcomers. So, I propose these two changes:

  • No longer mention annotations and just display attributes like everywhere else in the docs
  • Remove the brief mention to Flex in this article (first, because we need to reword it entirely now that we removed the annotations; second, because we already mention this and more in the previous setup.rst article)

Thanks!

@javiereguiluz javiereguiluz added this to the 6.2 milestone Jul 3, 2023
@carsonbot carsonbot changed the title Remove annotations from Creating Pages article [Routing] Remove annotations from Creating Pages article Jul 3, 2023
@javiereguiluz javiereguiluz merged commit 38391bf into symfony:6.2 Jul 4, 2023
@javiereguiluz javiereguiluz deleted the no_annotations branch July 4, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Routing Status: Needs Review
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@javiereguiluz @carsonbot
0