[DependencyInjection] Add defined prefix for env var processor #18464

GaryPEGEOT · 2023-06-28T19:53:21Z

javiereguiluz · 2023-06-29T06:46:46Z

Thanks Gary for contributing this!

While merging, we did some tweaks: 7f31c49

We removed "defined" from the description because it's recommended to not include the worde being described in its own description (this is a bit confusing --> "defined [...] returns true if the env var is defined [...]")
We renamed the env var of the example from NO_FOO to just FOO. I see the NO_COLOR example mentioned in the code PR, but using negated env vars makes the example harder to understand.

GaryPEGEOT · 2023-06-29T07:26:38Z

Hi @javiereguiluz! Thanks! I think there's a small typo: #18465

[DependencyInjection] Add defined prefix for env var processor

b9f2a57

Fixes #18462

carsonbot added Status: Needs Review DependencyInjection labels Jun 28, 2023

carsonbot added this to the 6.4 milestone Jun 28, 2023

javiereguiluz added Status: Reviewed and removed Status: Needs Review labels Jun 29, 2023

javiereguiluz merged commit 8d0b4a5 into symfony:6.4 Jun 29, 2023

GaryPEGEOT deleted the patch-1 branch June 29, 2023 07:22

Provide feedback