8000 [Validator] Update the ignoreNull option of UniqueEntity constraint by javiereguiluz · Pull Request #18335 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Update the ignoreNull option of UniqueEntity constraint #18335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

[Validator] Update the ignoreNull option of UniqueEntity constraint #18335

merged 1 commit into from
May 23, 2023

Conversation

javiereguiluz
Copy link
Member

Fixes #18324.

@javiereguiluz javiereguiluz added this to the 6.3 milestone May 22, 2023
@javiereguiluz
Copy link
Member Author

I don't understand DOCtor-RST error 🤔 // @OskarStark

OskarStark
OskarStark reviewed May 22, 2023
View reviewed changes
@OskarStark OskarStark mentioned this pull request May 22, 2023
Closed
VincentLanglet
VincentLanglet reviewed May 22, 2023
View reviewed changes
reference/constraints/UniqueEntity.rst Outdated
``ignoreNull``
~~~~~~~~~~~~~~

**type**: ``bool``, ``string`` or ``array`` **default**: ``[]``
Copy link
Contributor
@VincentLanglet VincentLanglet May 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**type**: ``bool``, ``string`` or ``array`` **default**: ``[]``
**type**: ``bool`` | ``array`` | ``string`` **default**: ``true``

I think this will fix the linter issue
AND the default value is still TRUE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vincent, thanks for reviewing this! I've just fixed the errors that you reported. Thanks.

@javiereguiluz javiereguiluz merged commit 28a7912 into symfony:6.3 May 23, 2023
@javiereguiluz javiereguiluz mentioned this pull request May 23, 2023
Closed
@javiereguiluz javiereguiluz deleted the fix_18324 branch May 23, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@VincentLanglet VincentLanglet VincentLanglet left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Needs Review Validator
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @OskarStark @VincentLanglet @carsonbot
0