8000 [Notifier] Add Ntfy bridge by mikaelkael · Pull Request #18253 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content
/ symfony-docs Public

[Notifier] Add Ntfy bridge #18253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2023
Merged

[Notifier] Add Ntfy bridge #18253

merged 1 commit into from
Jul 4, 2023

Conversation

mikaelkael
Copy link
Contributor

In addition with symfony/symfony#50131 for the new Ntfy notifier bridge

@carsonbot carsonbot added this to the 6.3 milestone Apr 25, 2023
@carsonbot carsonbot changed the title [Notifier]: add Ntfy bridge and links to push bridges' README [Notifier] : add Ntfy bridge and links to push bridges' README Apr 25, 2023
@mikaelkael mikaelkael mentioned this pull request Apr 25, 2023
Merged
@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Apr 25, 2023
@carsonbot carsonbot modified the milestones: 6.3, next Apr 25, 2023
OskarStark
OskarStark reviewed Apr 25, 2023
View reviewed changes
OskarStark
OskarStark reviewed Apr 25, 2023
View reviewed changes
@OskarStark OskarStark changed the title [Notifier] : add Ntfy bridge and links to push bridges' README [Notifier] Add Ntfy bridge and links to push bridges' README Apr 25, 2023
@OskarStark
Copy link
Contributor

Would you open a PR against 5.4 branch for and links to push bridges' README?

That would be helpful

@mikaelkael
Copy link
Contributor Author

Would you open a PR against 5.4 branch for and links to push bridges' README?

That would be helpful

Only against 5.4 branch? Not 6.x other versions ?

@mikaelkael mikaelkael mentioned this pull request Apr 25, 2023
Merged
OskarStark added a commit that referenced this pull request Apr 26, 2023
@OskarStark
minor #18254 [Notifier] Add links to push bridges' README (mikaelkael)
a49c293 
This PR was merged into the 5.4 branch.

Discussion
----------

[Notifier] Add links to push bridges' README

As requested in #18253

Commits
-------

3175594 [Notifier] Add links to push bridges' README
@mikaelkael
Copy link
Contributor Author

@OskarStark : I will review this PR after merge of #18257 to only have addition of Ntfy bridge (not all bridges links)

@mikaelkael mikaelkael changed the title [Notifier] Add Ntfy bridge and links to push bridges' README [Notifier] Add Ntfy bridge Apr 26, 2023
@OskarStark
Copy link
Contributor

Rebase unlocked ✅

Thank you for the other Pr's 🙏

OskarStark
OskarStark reviewed Apr 26, 2023
View reviewed changes
OskarStark
OskarStark approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my comment

OskarStark
OskarStark approved these changes Apr 28, 2023
View reviewed changes
notifier.rst Outdated
@@ -436,7 +437,7 @@ Service Package DSN

.. versionadded:: 6.3

The PagerDuty and Pushover integrations were introduced in Symfony 6.3.
The Ntfy, PagerDuty and Pushover integrations were introduced in Symfony 6.3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a 6.4 block, as we are in feature freeze phase right now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OskarStark : yes, I will review it when the 6.4 branch will be ready

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ready now

@mikaelkael mikaelkael changed the base branch from 6.3 to 6.4 May 29, 2023 10:27
@mikaelkael
Copy link
Contributor Author

@OskarStark : doc PR against 6.4, code rebased for 6.4 and recipes added 😊

fabpot added a commit to symfony/symfony that referenced this pull request Jun 20, 2023
@fabpot
feature #50131 [Notifier] add Ntfy bridge (mikaelkael)
b51e2d3 
This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Notifier] add Ntfy bridge

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#18253
| Recipes PR    | symfony/recipes#1204

Add [Ntfy](https://ntfy.sh/) notifier bridge

Commits
-------

c097511 [Notifier] add Ntfy bridge
@OskarStark OskarStark requested a review from javiereguiluz July 4, 2023 04:30
@javiereguiluz javiereguiluz added Status: Reviewed and removed Status: Needs Review Waiting Code Merge Docs for features pending to be merged labels Jul 4, 2023
@javiereguiluz
Copy link
Member

Merged! Thanks Mickael.

@javiereguiluz javiereguiluz merged commit 55a46e7 into symfony:6.4 Jul 4, 2023
@xabbuh xabbuh modified the milestones: next, 6.4 Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@mikaelkael @OskarStark @javiereguiluz @xabbuh @carsonbot
0