-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Revamping Multiple Kernels documentation #18186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8341d06
to
1d1658d
Compare
Lint failures are false positive in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really useful rewrite :)
Thanks for your feedback @94noni! I will take care of them soon. |
838899f
to
49b969a
Compare
84c941b
to
f1698a4
Compare
Yonel, what an impressive contribution 🙇🙇 This is really useful and your explanations were very detailed and practical. It's amazing! While merging I did some tweaks (see b3bee8e). Even if it looks like it's a lot of changes, in reality it's not:
So, in practice, 99% of your original contribution remained 🙏 Thanks! |
Thank you Javier for the tweaks! I will take them into account next time 👍 |
Minor tweaks about a visual issue in the directory structure #18279 |
Doctor-rst complains about name Do you think we can update docs with this naming (PR #18295) ? or we must add it to |
…rst (alamirault) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Fix pipeline] multiple_kernels.rst must respect doctor-rst #18186 (comment) `apps` -> `applications` `ContainerConfigurator $container` -> `ContainerConfigurator $containerConfigurator` Commits ------- 07f6609 [Fix pipeline] multiple_kernels.rst must respect doctor-rst
As we discussed on Slack, this approach will simplify and remove the boilerplate code while the result and goals are the same as before.