8000 [HttpCache] Fix decorating `http_cache` xml example by HypeMC · Pull Request #18063 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[HttpCache] Fix decorating http_cache xml example #18063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2023
Merged

[HttpCache] Fix decorating http_cache xml example #18063

merged 1 commit into from
Mar 16, 2023

Conversation

HypeMC
Copy link
Member
@HypeMC HypeMC commented Mar 15, 2023 •
edited
Loading

Followup to #17972 . The xml example is missing the <services> tag.

@HypeMC HypeMC force-pushed the explain-how-to-extend-the-httpcache-2 branch from 109159b to 6641fa5 Compare March 15, 2023 21:26
@HypeMC HypeMC changed the title [HttpCache] Decorate http_cache only in prod env [HttpCache] Fix decorating http_cache xml example Mar 15, 2023
@HypeMC HypeMC changed the base branch from 6.2 to 5.4 March 15, 2023 21:27
@javiereguiluz javiereguiluz added this to the 5.4 milestone Mar 16, 2023
@javiereguiluz
Copy link
Member

Good catch, thanks @HypeMC.

@javiereguiluz javiereguiluz merged commit 4e889ec into symfony:5.4 Mar 16, 2023
@HypeMC HypeMC deleted the explain-how-to-extend-the-httpcache-2 branch March 16, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
4FA0 No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@HypeMC @javiereguiluz @carsonbot
0