8000 [DependencyInjection] Add `closure` argument type by alexandre-daubois · Pull Request #17792 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] Add closure argument type #17792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2023
Merged

[DependencyInjection] Add closure argument type #17792

merged 1 commit into from
Feb 3, 2023

Conversation

alexandre-daubois
Copy link
Member

Fixes #16667

@carsonbot carsonbot added this to the 6.1 milestone Jan 22, 2023
alamirault
alamirault reviewed Jan 27, 2023
View reviewed changes
service_container.rst Outdated
}
}

Now, our configuration would look like this:
Copy link
Contributor
@alamirault alamirault Jan 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can maybe avoid repeat Now, ... which is used just above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, updated!

@javiereguiluz javiereguiluz changed the base branch from 6.1 to 6.2 February 3, 2023 09:41
@javiereguiluz
Copy link
Member

Thanks Alex! Yet another superb contribution 🙇 I'm running out of messages to thank you for your amazing contributions 😃

Note: I merged it in 6.2 and up because 6.0 and 6.1 are no longer supported.

@javiereguiluz javiereguiluz merged commit c5c1c78 into symfony:6.2 Feb 3, 2023
@alexandre-daubois
Copy link
Member Author

Thank you very much Javier! 🙏😃

@alexandre-daubois alexandre-daubois deleted the closure-tag-dic branch February 3, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamirault alamirault alamirault approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

[DependencyInjection] Add argument type closure to help passing closu…
4 participants
@alexandre-daubois @javiereguiluz @alamirault @carsonbot
0