8000 [Uid] Add `UuidFactory` and `UlidFactory` mentions by alexandre-daubois · Pull Request #17690 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Uid] Add UuidFactory and UlidFactory mentions #17690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

[Uid] Add UuidFactory and UlidFactory mentions #17690

merged 1 commit into from
Jan 9, 2023

Conversation

alexandre-daubois
Copy link
Member

Solves #14960

@carsonbot carsonbot added this to the 5.4 milestone Jan 8, 2023
@OskarStark
Copy link
Contributor

We could use CPP after upmerge starting from 6.0, to make the example more slim

@alexandre-daubois
Copy link
Member Author

Definitely!

@javiereguiluz
Copy link
Member

Nice addition! Thanks Alexandre.

@javiereguiluz javiereguiluz merged commit 138546c into symfony:5.4 Jan 9, 2023
@alexandre-daubois alexandre-daubois deleted the feat/uuid-factory branch January 9, 2023 16:50
@alexandre-daubois alexandre-daubois mentioned this pull request Jan 9, 2023
Merged
OskarStark added a commit that referenced this pull request Jan 9, 2023
@OskarStark
minor #17699 [Uid] Use constructor property promotion for UuidFactory…
8677542 
… and UlidFactory examples (alexandre-daubois)

This PR was merged into the 6.0 branch.

Discussion
----------

[Uid] Use constructor property promotion for UuidFactory and UlidFactory examples

Following `@OskarStark`'s idea (#17690 (comment)), here is a little improvement on Uid factories for 6.0+ 👍

Commits
-------

5232e0d [Uid] Use constructor property promotion for UuidFactory and UlidFactory examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Uid
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandre-daubois @OskarStark @javiereguiluz @carsonbot
0