8000 Standardize the name of the container builder variable 5.4 by alamirault · Pull Request #17683 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Standardize the name of the container builder variable 5.4 #17683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2023
Merged

Standardize the name of the container builder variable 5.4 #17683

merged 1 commit into from
Jan 7, 2023

Conversation

alamirault
Copy link
Contributor

Like ContainerConfigurator $containerConfigurator, use always ContainerBuilder $containerBuilder.

I think $container can be confusing

@carsonbot carsonbot added this to the 5.4 milestone Jan 7, 2023
@alamirault alamirault force-pushed the feature/standardize-container-builder-variable-54 branch from 5985d52 to 745f9db Compare January 7, 2023 15:13
OskarStark
OskarStark approved these changes Jan 7, 2023
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@javiereguiluz
Copy link
Member

Nice! Thanks Antoine

@javiereguiluz javiereguiluz merged commit ae687ab into symfony:5.4 Jan 7, 2023
@alamirault alamirault mentioned this pull request Jan 7, 2023
Merged
javiereguiluz added a commit that referenced this pull request Jan 9, 2023
@javiereguiluz
minor #17687 Standardize the name of the container builder variable 6…
37d54ed 
….1 (alamirault)

This PR was merged into the 6.1 branch.

Discussion
----------

Standardize the name of the container builder variable 6.1

#17683 For 6.1 branch (6.0 is ok)

Commits
-------

bfa6910 Standardize the name of the container builder variable 6.1
@dkarlovi dkarlovi mentioned this pull request Jan 23, 2023
Closed
@alamirault alamirault deleted the feature/standardize-container-builder-variable-54 branch May 9, 2023 11:11
@alamirault alamirault mentioned this pull request May 9, 2023
Closed
@nicolas-grekas nicolas-grekas mentioned this pull request May 10, 2023
Merged
OskarStark added a commit that referenced this pull request May 19, 2023
@OskarStark
minor #18299 Use "$container" consistently (nicolas-grekas)
f92acdb 
This PR was merged into the 5.4 branch.

Discussion
----------

Use "$container" consistently

Takes the other road from #17683 as discussed in #18295

Using `$containerBuilder` and `$containerConfigurator` is unnecessarily long, consuming horizontal space without adding any clarity.

This also aligns the name `$container` with existing practice in the code and in recipes.

Commits
-------

26d021c Use "$container" consistently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assig 50A8 ned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alamirault @javiereguiluz @OskarStark @carsonbot
0