8000 [DependencyInjection] 6.0 [injection_types] remove mention of @required in service_container by alexislefebvre · Pull Request #17655 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

[DependencyInjection] 6.0 [injection_types] remove mention of @required in service_container#17655

Merged
javiereguiluz merged 1 commit intosymfony:6.0from
alexislefebvre:6.0-remove-mention-to-required-2
Jan 7, 2023
Merged

[DependencyInjection] 6.0 [injection_types] remove mention of @required in service_container#17655
javiereguiluz merged 1 commit intosymfony:6.0from
alexislefebvre:6.0-remove-mention-to-required-2

Conversation

@alexislefebvre
Copy link
Copy Markdown
Contributor
@alexislefebvre alexislefebvre commented Jan 5, 2023

Same logic than in #17654:

Symfony 6+ requires PHP 8, so #[Required] can be used in all cases, and mentioning @required doesn't add any value.

@carsonbot carsonbot added this to the 6.0 milestone Jan 5, 2023
@alexislefebvre alexislefebvre changed the title 6.0 [injection_types] remove mention to required in service_container 6.0 [injection_types] remove mention of @required in service_container Jan 6, 2023
@carsonbot carsonbot changed the title 6.0 [injection_types] remove mention of @required in service_container [DependencyInjection] 6.0 [injection_types] remove mention of @required in service_container Jan 7, 2023
@javiereguiluz
Copy link
Copy Markdown
Member

Thanks!

@javiereguiluz javiereguiluz merged commit b0d6f80 into symfony:6.0 Jan 7, 2023
@alexislefebvre alexislefebvre deleted the 6.0-remove-mention-to-required-2 branch January 7, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0