8000 [Messenger] remove wrong `versionadded` for `AsMessageHandler` by Ehyiah · Pull Request #17493 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

[Messenger] remove wrong versionadded f 8000 or AsMessageHandler #17493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Ehyiah
Copy link
@Ehyiah Ehyiah commented Dec 2, 2022

as this attribute was added in 5.4 (Class exist in 5.4 branch and this post mention it too https://symfony.com/blog/new-in-symfony-5-4-messenger-improvements).

This message is also not present in 6.0 branch but present on 6.1, 6.2 and 6.3 branches, this may be an error.

.. versionadded:: 6.1
Support for #[AsMessageHandler] on methods was introduced in Symfony 6.1.

as this attribute was added in 5.4 (Class exist in 5.4 branch and this post mention it too https://symfony.com/blog/new-in-symfony-5-4-messenger-improvements).

This message is also not present in 6.0 branch but present on 6.1, 6.2 and 6.3 branches, this may be an error.

.. versionadded:: 6.1
    Support for ``#[AsMessageHandler]`` on methods was introduced in Symfony 6.1.
@Ehyiah Ehyiah changed the title remove wrong versionadded for AsMessageHandler [Messenger] remove wrong versionadded for AsMessageHandler Dec 2, 2022
@OskarStark OskarStark changed the title [Messenger] remove wrong versionadded for AsMessageHandler [Messenger] remove wrong versionadded for AsMessageHandler Dec 5, 2022
@OskarStark
Copy link
Contributor
OskarStark commented Dec 5, 2022

Based on the code PR

The versionadded is correct on 6.1 branch

👎 from my side on this PR unless I am missing something

@Ehyiah
Copy link
Author
Ehyiah commented Dec 5, 2022

Oh my, i'm sorry, I was the one missing something, you are indeed right !
Sorry for wasting your time.

@Ehyiah Ehyiah closed this Dec 5, 2022
@Ehyiah Ehyiah deleted the patch-1 branch December 5, 2022 06:54
@OskarStark
Copy link
Contributor

Oh my, i'm sorry, I was the one missing something, you are indeed right !
Sorry for wasting your time.

No problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0