8000 Add hint about variables_order ini setting required by DracoBlue · Pull Request #17267 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Add hint about variables_order ini setting required #17267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Add hint about variables_order ini setting required #17267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion configuration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,9 @@ the right situation:
but the overrides only apply to one environment.

*Real* environment variables always win over env vars created by any of the
``.env`` files.
``.env`` files. This behavior depends on
`variables_order <http://php.net/manual/en/ini.core.php#ini.variables-order>`_ to
contain an ``E`` to expose the ``$_ENV`` superglobal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly ping @stof @nicolas-grekas

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's wait for their review because this change is really important, so we must be sure it's correct. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dotenv has a fallback reading from $_SERVER (for env variables not starting with HTTP_ to avoid security issues due to confusion with HTTP headers), but I'm not sure the CLI populates it. So it should support the case of not having E in the order as long as you don't rely on env variables starting with HTTP_

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof we've just received another user report from someone facing an issue because of this. So, I think we should merge this PR, unless you are against it. Thanks.


The ``.env`` and ``.env.<environment>`` files should be committed to the
repository because they are the same for all developers and machines. However,
Expand Down
0