10000 [Cache] Add return hint by mohamedGasmii · Pull Request #17189 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Add return hint #17189

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2022
Merged

[Cache] Add return hint #17189

merged 1 commit into from
Aug 22, 2022

Conversation

mohamedGasmii
Copy link
Contributor

No description provided.

@carsonbot carsonbot added this to the 5.4 milestone Aug 16, 2022
94noni
94noni revie 8000 wed Aug 17, 2022
View reviewed changes
http_cache/esi.rst Outdated
@@ -172,7 +172,7 @@ of the main page::
// ...
class NewsController extends AbstractController
{
public function latest($maxPerPage)
public function latest($maxPerPage): Response
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While here can you perhaps typehint the $maxPerPage as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done !

@xabbuh xabbuh modified the milestones: 5.4, 4.4 Aug 22, 2022
@xabbuh xabbuh changed the base branch from 5.4 to 4.4 August 22, 2022 08:10
@xabbuh xabbuh requested a review from OskarStark as a code owner August 22, 2022 08:10
@xabbuh
Copy link
Member
xabbuh commented Aug 22, 2022

Thank you @mohamedGasmii.

@xabbuh xabbuh merged commit 4927f53 into symfony:4.4 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@94noni 94noni 94noni left review comments

@xabbuh xabbuh xabbuh approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Cache Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mohamedGasmii @xabbuh @94noni @carsonbot
0