Yet another attempt for consistent variable naming ;-) #17134
Conversation
Following the convention you showed me in symfony#16560, the variable's name here should be `$config`. **So I'm suggesting: Use the full class name as variable name everywhere in config**: `$containerConfigurator`, `$frameworkConfig`, `$securityConfig`, etc.
|
I'm not sure I follow your reasoning. We use Also, what we do in the docs for examples like #16560 and this PR is:
Personally I'm fan of long variable names, but in this case I think it makes sense to make the code more readable by removing the prefix before Of course we can discuss about changing this practice (nothing is immutable in Symfony Docs) but given the burden for maintainers, any big impact change like this must be much better than the previous situation, to justify the effort of updating everything, dealing with merge conflicts, etc. That's why I'm closing this without merging, but I hope you understand the given reasons. Thanks. |
|
@javiereguiluz In #16560 (comment) you told me the exact opposite! Here you're saying:
There you said:
|
|
@ThomasLandauer sorry! I've just reworded my previous message a bit. What I wanted to say was that I think it's OK in these two (different but related) cases to not use the full-length variable names to make code examples a bit more readable. |
|
@javiereguiluz What I mean is if you don't want to use the full name, then you should always use either the first or the second part. Right now, it's sometimes the first, sometimes the second - based on a subtle difference that nobody notices ;-) |
Following the convention you showed me in #16560, the variable's name here should be
$config;-)So I'm suggesting: Always use the full class name as variable name (in config files):
$containerConfigurator,$frameworkConfig,$securityConfig, etc.