8000 Adding that you cannot access a session inside a constructor by ThomasLandauer · Pull Request #16985 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Adding that you cannot access a session inside a constructor #16985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Adding that you cannot access a session inside a constructor #16985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions session.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,10 @@ if you type-hint an argument with :class:`Symfony\\Component\\HttpFoundation\\Re
public function __construct(RequestStack $requestStack)
{
$this->requestStack = $requestStack;

// Accessing the session in the constructor is *NOT* reommended, since
// it might not be accessible yet or lead to unwanted side-effects
// $this->session = $requestStack->getSession();
}

public function someMethod()
Expand Down
0