8000 [Messenger] fix xml block by kbond · Pull Request #16762 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] fix xml block #16762

New iss 8000 ue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2022
Merged

[Messenger] fix xml block #16762

merged 1 commit into from
May 4, 2022

Conversation

kbond
Copy link
Member
@kbond kbond commented Apr 29, 2022

Fixes #16451.

@carsonbot carsonbot added this to the 5.4 milestone Apr 29, 2022
ogizanagi
ogizanagi 8000 approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor
@ogizanagi ogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding a note about the fact it'll be the default as of Symfony 6.0 and add a note about disabling this behavior explicitly using --no-reset (as explained in #16763)?

@kbond kbond force-pushed the reset-on-message-xml branch from 0fd354e to c150197 Compare May 2, 2022 18:23
@kbond
Copy link
Member Author
kbond commented May 2, 2022

Note added.

ogizanagi
ogizanagi approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor
@ogizanagi ogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌🏻

@javiereguiluz javiereguiluz merged commit d5efe38 into symfony:5.4 May 4, 2022
@javiereguiluz
Copy link
Member

Thanks Kevin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Messenger] "reset_on_message" location is inconsistent
4 participants
@kbond @javiereguiluz @ogizanagi @carsonbot
0