8000 [Mime] Allow to embed images as CSS backgrounds by javiereguiluz · Pull Request #16633 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Mime] Allow to embed images as CSS backgrounds #16633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2022
Merged

[Mime] Allow to embed images as CSS backgrounds #16633

merged 1 commit into from
Mar 24, 2022

Conversation

javiereguiluz
Copy link
Member

Fixes #16492.

@javiereguiluz javiereguiluz added this to the 6.1 milestone Mar 21, 2022
@javiereguiluz javiereguiluz merged commit 25a9f9a into symfony:6.1 Mar 24, 2022
@javiereguiluz javiereguiluz mentioned this pull request Mar 24, 2022
Closed
@javiereguiluz javiereguiluz deleted the fix_16492 branch March 25, 2022 17:00
@flack
Copy link
flack commented Mar 26, 2022

I don't think this is correct: What I implemented in symfony/symfony#45376 is only support for the old-timey background="" attribute, not for CSS background-image (see also the PR description). It could be added realtively easily and it would certainly be nice to have, but it's not implemented as of now

@javiereguiluz
Copy link
Member Author

@flack thanks for telling me about this error. I've fixed it in b39f0de Cheers!

@flack
Copy link
flack commented Mar 28, 2022

@javiereguiluz sorry, but that's still not right. What I implemented was only support for this:

<div background="cid:some-img.png"></div>

So really the HTML attribute background, not the CSS property by the same name

@javiereguiluz
Copy link
Member Author
javiereguiluz commented Mar 28, 2022 •
edited
Loading

@flack fixed again! Thanks.

See 868e311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Mime Status: Needs Review
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @flack @carsonbot
0