[Security] Document the new remember me system #16376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some line to the Authenticator to add a RememberMeBadge to the Passport returned
I had to search a while for myself not understanding why I did not have a REMEMBERME cookie when I activated the new system. So maybe handy to add it.
This was referenced Jan 7, 2022
79a417f to
c2b7040
Compare
gnito-org
reviewed
Jan 11, 2022
gnito-org
reviewed
Jan 11, 2022
gnito-org
reviewed
Jan 11, 2022
gnito-org
reviewed
Jan 11, 2022
gnito-org
reviewed
Jan 11, 2022
c2b7040 to
5ac2d26
Compare
|
Thanks for the detailed review @gnito-org |
MarkPedron
reviewed
Jan 17, 2022
| After logging in, you can use the security profiler to see if this badge is | ||
| present: | ||
|
|
||
| .. image:: /_images/security/profiler-badges.png |
There was a problem hiding this comment.
Can you add an alt attribute to improve accessibility?
There was a problem hiding this comment.
Suggested change
| .. image:: /_images/security/profiler-badges.png | |
| .. image:: /_images/security/profiler-badges.png | |
| :alt: A RememberMeBadge dumped in the security profiler passport column |
javiereguiluz
approved these changes
Jan 19, 2022
|
Wouter, thanks a lot for your continuous work on Symfony Docs, especially in security-related docs 🙏 If you agree, I'll let you merge this one because you'll deal with upmerge conflicts better than I'll do. Thanks! |
|
Thanks for the review, @javiereguiluz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15721, fixes #16149
Replaces #15464, replaces #15893
Ref #15908
In Symfony 5.3, along with the new authentication system, we also somewhat silently introduced a new remember me system. Time to update the remember me docs with all new features :)
This PR also includes 2 commits from open PRs in this repository. We've been very late with this one, and community members have already invested time in contributing necessary changes to the docs before. They deserve the credits :)
@javiereguiluz I'm sorry for not informing you of this work before, I see you just merged a third PR that is replaced by this one.