8000 [Configuration] Multiple environments in a single file by MaximePinot · Pull Request #16313 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Configuration] Multiple environmen 8000 ts in a single file #16313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2022
Merged

[Configuration] Multiple environments in a single file #16313

merged 2 commits into from
Jan 16, 2022

Conversation

MaximePinot
Copy link
Contributor

As @BafS mentioned in the Symfony slack, the new Symfony 5.3 feature about defining options for different environments in a single file is not documented, apart from this blog post. I could not find anything about it in the documentation either.

Here is a proposal to include the blog post in the documentation.

I put it in a tip section. Perhaps it is worth putting it in a new section below Configuration Environments (or as a subsection) ? 🤔

@carsonbot carsonbot added this to the 5.3 milestone Dec 22, 2021
@BafS
Copy link
Contributor
BafS commented Dec 22, 2021

Thanks for the commit!

To not loose track of it, here is the issue: #15253

94noni
94noni reviewed Dec 22, 2021
View reviewed changes
@wouterj
Copy link
Member
wouterj commented Jan 16, 2022

Thanks for adding the mention of this nice feature to the docs, Maxime! I've moved the #[When] docs to the Service Container guide. For now, let's keep this relatively low-profile. We're in the process of moving all official recipes to use this when feature and will update all docs when this becomes the new official standard.

@wouterj wouterj merged commit e0ba536 into symfony:5.3 Jan 16, 2022
@wouterj wouterj mentioned this pull request Jan 16, 2022
Closed
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 16, 2022
Closed
@MaximePinot MaximePinot deleted the patch-1 branch January 16, 2022 17:09
@kbond kbond mentioned this pull request Dec 14, 2022
Closed
9 tasks
@ThomasLandauer ThomasLandauer mentioned this pull request Jan 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@94noni 94noni 94noni approved these changes

Assignees
No one assigned
Labels
4F91 Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@MaximePinot @BafS @wouterj @94noni @carsonbot
0