Update mercure.rst regarding JWT token secret #16151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 The documentation for the configuration of mercure seems quite wrong: it has 8000 a big "caution" block stating that the `MERCURE_JWT_SECRET` should contain an _actual JWT_ ... instead of a secret, which is weird (and definitely not how it works). I propose to remove these (maybe out of date?) parts to prevent further confusion (_I spent a full day examining the actual source to understand what was really needed in the env var_). Also, added a tip on how setting the cookies twice would not work. PS: I created this PR against the 5.3 (current) branch since the 4.4 branch does not have the same paragraphs. Hope it's good.
|
Thanks for this contribution. However, before merging we'll need some review from a Mercure expert (@dunglas maybe?) Thanks! |
|
Indeed this is outdated but it's still possible to use a "static" JWT as described in this section by setting the |
javiereguiluz
added a commit
that referenced
this pull request
Dec 20, 2021
…various improvements (tchapi, dunglas) This PR was merged into the 5.3 branch. Discussion ---------- [Mercure] Compatibility with the Docker integration and various improvements Includes #16151. Closes dunglas/symfony-docker#200. Commits ------- ad0cbe5 nitpicking adf49ef Update mercure.rst daaa3f1 Update mercure.rst ec87085 Update mercure.rst b4fb9fb Update mercure.rst 3ca1aa1 Update mercure.rst 81c1387 Update mercure.rst e35f1cc Update mercure.rst 7496149 review 142a6f9 [mercure] Compatibility with the Docker integration and various improvements 123ad73 Remove unneeded JWT reference f948ab2 Update mercure.rst regarding JWT token secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
The documentation for the configuration of mercure seems quite wrong: it has a big "caution" block stating that the
MERCURE_JWT_SECRETshould contain an actual JWT ... instead of a secret, which is weird (and definitely not how it works).I propose to remove these (maybe out of date?) parts to prevent further confusion (I spent a full day examining the actual source to understand what was really needed in the env var).
Also, added a tip on how setting the cookies twice would not work.