8000 unify expression: yarn run encore -> yarn encore by nabbisen · Pull Request #15862 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

unify expression: yarn run encore -> yarn encore 8000 #15862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2021
Merged

unify expression: yarn run encore -> yarn encore #15862

merged 1 commit into from
Oct 4, 2021

Conversation

nabbisen
Copy link
Contributor

This commit unifies expression on yarn: yarn run encore ... -> yarn encore ... same to above in the same page.

@javiereguiluz javiereguiluz changed the base branch from 5.4 to 4.4 October 4, 2021 09:13
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner October 4, 2021 09:13
@javiereguiluz javiereguiluz merged commit c4c4065 into symfony:4.4 Oct 4, 2021
@javiereguiluz
Copy link
Member

@nabbisen thanks for improving this! Please note that while merging we changed this a bit ... because in the rest of the docs we use yarn encore ... instead of yarn run ... so it's more consistent to use the first pattern. Thanks!

@nabbisen
Copy link
Contributor Author
nabbisen commented Oct 5, 2021

@javiereguiluz
I'm so sorry I made a mistake on the change. Yes, I understand yarn encore ... is used, for I have read docs about encore. Thank you for your reviewing and fixing my silly mistake.

@javiereguiluz
Copy link
Member

@nabbisen no worries at all! This was a good catch of yours, seeing that there was an inconsistency in the docs. It's just that the preferred fix was slightly different, but that's totally fine 👍 We hope to see more contributions from you in the future. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0