[Routing] rewrite incorrect sentence #15824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seb33300
reviewed
Sep 17, 2021
|
@Ahummeling thanks for this fix. I agree that the original text is wrong. However, I think we should fix differently. Instead of mentioning the |
|
Yeah, that actually makes much more sense. I'll go make the changes and update my PR, thanks! |
d242727 to
55b322d
Compare
|
Arend, thanks for making these additional changes. It's merged now! Congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bit of documentation:
This feature is called "param converter" and is only available when using annotations to define routes.Would imply that the param converter is only enabled for routes that are defined through annotations. But I believe this is not case.This pull request rewrites this sentence and would hopefully prevent other people from also spending a lot of time unnecessarily.