8000 docs: Fix form collection example by chapterjason · Pull Request #15774 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

docs: Fix form collection example #15774

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2021
Merged

docs: Fix form collection example #15774

merged 1 commit into from
Sep 3, 2021

Conversation

chapterjason
Copy link
Contributor

First reported here: symfony/symfony#42870

Not sure which branch, took the lowest one where this occurs.

@chapterjason chapterjason marked this pull request as ready for review September 3, 2021 11:51
@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.3, 5.4, 6.0.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 5.2 milestone Sep 3, 2021
@chapterjason chapterjason requested a review from xabbuh as a code owner September 3, 2021 14:11
@chapterjason chapterjason changed the base branch from 5.2 to 5.3 September 3, 2021 14:14
@javiereguiluz javiereguiluz modified the milestones: 5.2, 5.3 Sep 3, 2021
@javiereguiluz
Copy link
Member

@chapterjason very good catch! Thanks for fixing this and congrats on your (super nice) first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit d410b3c into symfony:5.3 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0