8000 [Twig] Add PHP Attributes to routing configuration example by sebpacz · Pull Request #15744 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Twig] Add PHP Attributes to routing configuration example #15744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2021
Merged

[Twig] Add PHP Attributes to routing configuration example #15744

merged 1 commit into from
Sep 17, 2021

Conversation

sebpacz
Copy link
Contributor
@sebpacz sebpacz commented Aug 23, 2021

No description provided.

8000
@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.3, 5.4, 6.0.

Cheers!

Carsonbot

@carsonbot carsonbot added the Twig label Aug 23, 2021
@carsonbot carsonbot added this to the 5.2 milestone Aug 23, 2021
@sebpacz sebpacz changed the base branch from 5.2 to 5.3 August 23, 2021 19:26
@javiereguiluz javiereguiluz modified the milestones: 5.2, 5.3 Sep 17, 2021
@javiereguiluz
Copy link
Member

Thanks Sebastian! Sorry it took us so long to merge.

@javiereguiluz javiereguiluz merged commit 0f85c22 into symfony:5.3 Sep 17, 2021
@sebpacz sebpacz deleted the attributes-configuration branch September 23, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed Twig
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@sebpacz @carsonbot @javiereguiluz
0